They make sense for the multi-monitor, all-day-screen reality of trading. Several bright displays mean a lot of glare and brightness, and a quality tinted lens takes the edge off over a long session, which many heavy screen users find more comfortable. If your trading runs into the evening, an amber lens also protects your sleep.
As always, they're a comfort-and-sleep layer, not a focus enhancer. Pair them with matched brightness across your monitors, the 20-20-20 rule, and breaks, and your eyes hold up better through the session.